new ignition switch but wont come on

Re-check your wiring. There should be three wires going to your ignition switch. One is ground, one runs the starter, and one is for power on in the run position. If your starter is running, but the car turns off when you release the key, it sounds like your power on wire is not connected or otherwise not functioning correctly.